Simple Musig2 implementation #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple Musig2/BIP327 (https://github.com/bitcoin/bips/blob/master/bip-0327.mediawiki) that uses primitives provided by our secp256k1 wrapper. It is meant to be used for testing and prototyping. Reference test vectors have also been imported.
t-bast
reviewed
Dec 4, 2023
t-bast
reviewed
Dec 6, 2023
We'll add better error managememt when we switch to a native implementation of musig2 (through secp256k1-kmp).
t-bast
approved these changes
Dec 6, 2023
|
One of the limitations of using nullable types for some of the musig2 methods is that is it understood by kotlin only. Scala/Java users will need to explicitly check against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple Musig2/BIP327 (https://github.com/bitcoin/bips/blob/master/bip-0327.mediawiki) that uses primitives provided by our secp256k1 wrapper. It is primarily meant to be used for testing and prototyping, we'll update secp256k1-kmp to use secp256k1-zkp or upgrade secp256k1 when it supports musig2 directly.
Reference test vectors have also been imported.